Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost rest api & fix memleak #1455

Merged
merged 9 commits into from
Sep 21, 2023
Merged

boost rest api & fix memleak #1455

merged 9 commits into from
Sep 21, 2023

Conversation

OdyWayne
Copy link
Collaborator

No description provided.

@OdyWayne
* MDF [rest api] set default sub option and add rap & rh option.
3499151 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne
* MDF [rest api] replace topic with remote and local topic in bridge.
f5dcd19 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne
* FIX [rest api test] enable real sub.
28e001b 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne
* FIX [rest api test] disable the buggy part for now.
b51c173 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne
* FIX [rest api] fix memleak of cp.
e85e4f3 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne
* FIX [rest api] adjust bridge sub.
6d3be1a 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne OdyWayne mentioned this pull request Sep 21, 2023
Closed
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited

Codecov Report

Patch coverage is 96.55% of modified lines.

Files Changed Coverage
nanomq/rest_api.c 96.55%

📢 Thoughts on this report? Let us know!.

@OdyWayne
* FIX [rest api] enable rap & rh.
416b962 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne
* FIX [rest api] fix memleak in bridge unsub.
7ff960f 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne OdyWayne mentioned this pull request Sep 21, 2023
Merged
@OdyWayne
* MDF [test conf] enable more features.
3150f31 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
wanghaEMQ
wanghaEMQ reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@wanghaEMQ wanghaEMQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you benchmark and do some fuzz or complex tests on restapi? I didn't get memory leakage before.

@OdyWayne
Copy link
Collaborator Author

Did you benchmark and do some fuzz or complex tests on restapi? I didn't get memory leakage before.

This could reproduce memleak :#1454

JaylinYu
JaylinYu approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you！！

@JaylinYu JaylinYu merged commit 49249d6 into master Sep 21, 2023
90 checks passed
@JaylinYu JaylinYu deleted the herman/dev branch September 21, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghaEMQ wanghaEMQ wanghaEMQ left review comments

@RanMaoyi RanMaoyi RanMaoyi approved these changes

@JaylinYu JaylinYu JaylinYu approved these changes

@xinyi-xs xinyi-xs xinyi-xs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@OdyWayne @RanMaoyi @JaylinYu @xinyi-xs @wanghaEMQ