Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws bridge test & docs fix #1478

Merged
merged 8 commits into from
Oct 9, 2023
Merged

aws bridge test & docs fix #1478

merged 8 commits into from
Oct 9, 2023

Conversation

OdyWayne
Copy link
Collaborator

@OdyWayne OdyWayne commented Oct 8, 2023

No description provided.

@OdyWayne
* FIX [docs] docs fix.
d871590 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne
* FIX [docs] aws bridge docs fix.
f142dd0 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne
* FIX [docs] aws bridge docs updated.
48115e0 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne
* FIX [log] update log level.
1665c29 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne
* FIX [docs] fix node example conf for aws bridge.
2497b31 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
RanMaoyi
RanMaoyi approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@RanMaoyi RanMaoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@OdyWayne
Copy link
Collaborator Author

OdyWayne commented Oct 8, 2023

should merge --> nanomq/NanoNNG#705 first

@OdyWayne
* MDF [aws test] updates for aws bridge test.
92d344b 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne
* MDF [aws test] updates for aws bridge test.
4653d9c 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@OdyWayne
SYNC
6319314 
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
nanomq/apps/broker.c 52.86% <100.00%> (+0.89%) ⬆️
nanomq/aws_bridge.c 80.62% <33.33%> (ø)

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

wanghaEMQ
wanghaEMQ reviewed Oct 8, 2023
View reviewed changes
Copy link
Member

@wanghaEMQ wanghaEMQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to make those keys public?

JaylinYu
JaylinYu requested changes Oct 8, 2023
View reviewed changes
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz remove the pem/key

@OdyWayne
Copy link
Collaborator Author

OdyWayne commented Oct 8, 2023

plz remove the pem/key

Without those, then CI for aws bridge test is impossible. We may need further discussion.

@JaylinYu
Copy link
Member

JaylinYu commented Oct 9, 2023

gonna merge it first.
need to have a limited aws iot core service

@JaylinYu JaylinYu merged commit f1a2e59 into master Oct 9, 2023
91 checks passed
@JaylinYu JaylinYu deleted the herman/dev branch October 9, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghaEMQ wanghaEMQ wanghaEMQ left review comments

@RanMaoyi RanMaoyi RanMaoyi approved these changes

@JaylinYu JaylinYu JaylinYu approved these changes

@xinyi-xs xinyi-xs xinyi-xs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@OdyWayne @JaylinYu @RanMaoyi @xinyi-xs @wanghaEMQ