topic reflection in aws bridge & docs update #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
Codecov ReportAttention:
... and 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
wanghaEMQ
reviewed
Oct 9, 2023
| @@ -123,12 +123,12 @@ bridges.aws.c1 { | |||
| subscription = [ | |||
| { | |||
| remote_topic = "cmd/topic1" | |||
| @@ -123,12 +123,12 @@ bridges.aws.c1 { | |||
| subscription = [ | |||
| { | |||
| remote_topic = "cmd/topic1" | |||
| local_topic = "topic1" | |||
| local_topic = "topic3" | |||
| qos = 0 | |||
| }, | |||
| { | |||
| remote_topic = "cmd/topic2" | |||
| @@ -126,12 +126,12 @@ bridges.aws.c1 { | |||
| subscription = [ | |||
| { | |||
| remote_topic = "cmd/topic1" | |||
| local_topic = "topic1" | |||
| local_topic = "topic3" | |||
| qos = 0 | |||
| }, | |||
| { | |||
| remote_topic = "cmd/topic2" | |||
| @@ -126,12 +126,12 @@ bridges.aws.c1 { | |||
| subscription = [ | |||
| { | |||
| remote_topic = "cmd/topic1" | |||
There was a problem hiding this comment.
I don't think it's a problem, remote_topic and local_topic are not strongly correlated.
xinyi-xs
approved these changes
Oct 9, 2023
JaylinYu
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.