Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* NEW [test] tests for mqtt_api #1513

Merged
merged 2 commits into from Nov 2, 2023
Merged

* NEW [test] tests for mqtt_api #1513

merged 2 commits into from Nov 2, 2023

Conversation

OdyWayne
Copy link
Collaborator

@OdyWayne OdyWayne commented Nov 1, 2023

No description provided.

Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
Copy link
Member

@wanghaEMQ wanghaEMQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the nano_pipe_get_remote_address?

@OdyWayne
Copy link
Collaborator Author

OdyWayne commented Nov 1, 2023

Where is the nano_pipe_get_remote_address?

That is a question you should answer. Why name it as nano_pipe_get_local_address at first place. XD

@JaylinYu
Copy link
Member

JaylinYu commented Nov 1, 2023

Where is the nano_pipe_get_remote_address?

That is a question you should answer. Why name it as nano_pipe_get_local_address at first place. XD

LOL I know what happened in the between

@wanghaEMQ
Copy link
Member

Where is the nano_pipe_get_remote_address?

That is a question you should answer. Why name it as nano_pipe_get_local_address at first place. XD

Hmmm I means both of them should be included in unit test.

@OdyWayne
Copy link
Collaborator Author

OdyWayne commented Nov 2, 2023

Where is the nano_pipe_get_remote_address?

That is a question you should answer. Why name it as nano_pipe_get_local_address at first place. XD

Hmmm I means both of them should be included in unit test.

You'll find out there is no nano_pipe_get_remote_address, if you check the whole file.

@JaylinYu JaylinYu merged commit 0e5066f into master Nov 2, 2023
89 checks passed
@JaylinYu JaylinYu deleted the herman/dev branch November 2, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants