Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug / Feature Lacking in function delete_perm() and delete_group() #42

Closed
rubim opened this issue Jun 3, 2015 · 3 comments
Closed

Bug / Feature Lacking in function delete_perm() and delete_group() #42

rubim opened this issue Jun 3, 2015 · 3 comments

Comments

@rubim
Copy link

rubim commented Jun 3, 2015

Hello,

I found the following some problem as described below:
Please take a look

public function delete_perm($perm_par) {
     ...........
     // deletes from perm_to_user table
     $this->aauth_db->where('perm_id', $perm_id);
     $this->aauth_db->delete($this->config_vars['perm_to_group']);
     .........
}

should be

public function delete_perm($perm_par) {
     ...........
     // deletes from perm_to_user table
     $this->aauth_db->where('perm_id', $perm_id);
     $this->aauth_db->delete($this->config_vars['perm_to_user']);
     .........
}

and in the another delete_group function(), we should add delete perms from perm_to_group table

public function delete_group($group_par) {
     // now users are deleted from user_to_group table
     $this->aauth_db->where('group_id', $group_id);
     $this->aauth_db->delete($this->config_vars['user_to_group']);

     // delete permission from perm_to_group table 
     // STARTS
     // now perms are deleted from perm_to_group table
     $this->aauth_db->where('group_id', $group_id);
     $this->aauth_db->delete($this->config_vars['perm_to_group']);
     // ENDS

     $this->aauth_db->where('id', $group_id);
     return $this->aauth_db->delete($this->config_vars['groups']);
}

Thank you !!!!

emreakay pushed a commit that referenced this issue Jul 27, 2015
@REJack
Copy link
Collaborator

REJack commented Jul 28, 2015

@emreakay please close this issue, its fixed with my last merged PR

@emreakay
Copy link
Owner

Now I'm mobile. I will close this when I get home

@emreakay
Copy link
Owner

closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants