Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add multiple params #18

Closed
ehamberg opened this issue Jan 28, 2023 · 2 comments
Closed

Cannot add multiple params #18

ehamberg opened this issue Jan 28, 2023 · 2 comments

Comments

@ehamberg
Copy link

ehamberg commented Jan 28, 2023

Shouldn't this set_query

for (k, v) in self.params.iter() {
self.uri.set_query(Some(format!("{}={}", k, v).as_str()));

…be something like the following?

    self.uri.query_pairs_mut().append_pair(k, v);

As it is now, if I add multiple parameters, like this:

.with_params()
.limit_to_first(50)
.start_at(1674526969)
.order_by("\"txid\"")
.finish()

Only the last one of them gets added to the URL.

@emreyalvac
Copy link
Owner

Hi,

Good catch. I will fix it.

@emreyalvac
Copy link
Owner

Hi @ehamberg,

Fixed in 2.0.6.

f38e8c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants