Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwrap() #3

Closed
y2kappa opened this issue May 28, 2020 · 2 comments
Closed

unwrap() #3

y2kappa opened this issue May 28, 2020 · 2 comments

Comments

@y2kappa
Copy link

y2kappa commented May 28, 2020

Hi,

Thanks for working on this. It's really great to have this functionality working out of the box with a lib from crates.io. I am integrating it into my server, but I have an issue. I think there are too many unwraps in the library and it doesn't seem I can avoid them.

get_generic unwraps and sometimes I don't know if the path exists and I don't want it to unwrap, I just want an error.

Do you accept PRs to make these as result instead?

Thanks

@emreyalvac
Copy link
Owner

emreyalvac commented May 29, 2020

Hi @y2kappa,

Thanks for issue.

You're right but lib. is still under development. If u want to send PR, of course i will review and accept.

Good works.

@bobbbay
Copy link

bobbbay commented Jul 20, 2021

Even better would be to implement Error on the error types. This way, you can ? out of them. It's astonishing that none of the errors in this crate don't have this done, especially since it's the standard way of create error enums in Rust - and it takes less than a minute to do!

Edit: I realize that this has been done on master but not released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants