Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian Language #1199

Closed
cicos99 opened this issue Jul 1, 2023 · 10 comments
Closed

Italian Language #1199

cicos99 opened this issue Jul 1, 2023 · 10 comments
Labels
enhancement New feature or request
Milestone

Comments

@cicos99
Copy link

cicos99 commented Jul 1, 2023

Hi everyone ,

in the attachment the files for the Italian language .
Sorry but I left only English and German because it was too messy to enter a new language ..
Greetings to all

ENG_DE_ITA_EMS_ESP32_v3.6_dev.zip

@proddy
Copy link
Contributor

proddy commented Jul 1, 2023

Thanks @cicos99 . We'll merge into dev after the other pending changes.

@proddy proddy added the enhancement New feature or request label Jul 1, 2023
@proddy proddy added this to the v3.6.0 milestone Jul 1, 2023
@MichaelDvP
Copy link
Contributor

Sorry but I left only English and German because it was too messy to enter a new language ..

A while ago i've converted to excel to make editing easier. I've added your translation, please check. There are some new translations for ventilation in the dev, could you please add the few missing, also some new in the web-index (i've renamed ts->txt for uploading here, last 20 lines are new).
BTW: Very good and complete work!

index.txt
locale_translations_w_it.xlsx

@MichaelDvP
Copy link
Contributor

@cicos99 The translation is included in the dev2 branch.
@proddy Should we add a Development-bin here to have more testers? I've build the dev2 to https://github.com/MichaelDvP/EMS-ESP32/releases/tag/latest

@proddy
Copy link
Contributor

proddy commented Jul 2, 2023

@MichaelDvP yes, was thinking the same. If you could extend the github actions are do a separate dev2 build that would be great.

Shall I look at getting the standalone C++ working?

@proddy
Copy link
Contributor

proddy commented Jul 3, 2023

IT added to the new Test build: https://github.com/emsesp/EMS-ESP32/releases/tag/test

@cicos99
Copy link
Author

cicos99 commented Jul 3, 2023

Sorry but I left only English and German because it was too messy to enter a new language ..

A while ago i've converted to excel to make editing easier. I've added your translation, please check. There are some new translations for ventilation in the dev, could you please add the few missing, also some new in the web-index (i've renamed ts->txt for uploading here, last 20 lines are new). BTW: Very good and complete work!

index.txt locale_translations_w_it.xlsx

EMS ESP ita.zip

Translation checked and filled with missing parts .
Perhaps not all correct because some words or idioms are not translatable or do not exist in Italian German etc. , therefore without having the possibility to verify everything due to the lack of all manageable devices it's difficult to say if the translation is correct or wrong

@proddy
Copy link
Contributor

proddy commented Jul 3, 2023

Thanks. If you have the repo forked you can test locally without needing to build and upload the firmware to an EMS-ESP. Just install nodejs/npm and yarn, and run yarn run standalone from the interface directory. For the first install, you will also need to runyarnin the mock-api folder. Instructions are in https://emsesp.github.io/docs/Building/#testing-locally

@proddy
Copy link
Contributor

proddy commented Jul 8, 2023

close this @MichaelDvP?

@MichaelDvP
Copy link
Contributor

I think it's all implemented, we have to ask @cicos99: Ok to close?

@proddy
Copy link
Contributor

proddy commented Jul 11, 2023

closing for now - can re-open if we find issues

@proddy proddy closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants