Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make discretize a dependency #84

Closed
5 of 11 tasks
prisae opened this issue Jan 15, 2020 · 3 comments
Closed
5 of 11 tasks

Make discretize a dependency #84

prisae opened this issue Jan 15, 2020 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@prisae
Copy link
Member

prisae commented Jan 15, 2020

Currently, discretize is not a dependency, and all could be done with utils.TensorMesh. However, this leads sometimes to confusion, and the gain is little. The main reasons why discretize has not been made a dependency are removed:

  • dependencies:
  • Installable via conda
  • Can be installed without prior installing numpy

So I think it is time to go all-in and make it a hard dependency (adjust docs and website) as soon as all boxes above are ticked and a release happened (pin the version then); utils.TensorMesh should then only be used internally.

I think the best would be to do in emg3d.meshes

from discretize import TensorMesh

and then rename the meshes.TensorMesh to meshes._TensorMesh, for internal use of the solver only.

Adjust accordingly:

  • emg3d.meshes
  • emg3d.io save/load
  • example-gallery
  • website
  • REAMDE
  • install instructions in docs
@prisae prisae added the enhancement New feature or request label Jan 15, 2020
@prisae prisae added this to the v1.0.0 milestone Jan 15, 2020
@prisae
Copy link
Member Author

prisae commented Feb 17, 2020

If so, replace emg3d.njitted.volume_average with discretize.utils.interputils.volume_average.

@prisae
Copy link
Member Author

prisae commented Jun 26, 2020

Will be closed by #109

@prisae
Copy link
Member Author

prisae commented Jul 13, 2020

Soft dependency.

@prisae prisae closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant