Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document possibilities of positive z upwards and downwards #47

Closed
3 tasks done
prisae opened this issue Oct 10, 2019 · 1 comment · Fixed by #70
Closed
3 tasks done

Document possibilities of positive z upwards and downwards #47

prisae opened this issue Oct 10, 2019 · 1 comment · Fixed by #70
Labels
docs Stuff related to the documentation examples Add to or improve the gallery

Comments

@prisae
Copy link
Member

prisae commented Oct 10, 2019

Change empymod from positive z downwards to positive z upwards, to be compatible with emg3d and most 'modern' geo-software and display tools.

Backwards incompatible, something for version 2.0.

See comment below, it is already possible. We just have to document it better:

  • Manual
  • Docstrings
  • Example notebook
@prisae prisae added this to the v2.0.0 milestone Oct 10, 2019
@prisae prisae added the maintenance Maintaining status quo label Oct 10, 2019
@prisae
Copy link
Member Author

prisae commented Jan 16, 2020

I gave it some more thoughts, and tested with some examples to confirm my guesses: It is already possible! As empymod does not make any assumption (not even of an air layer), it is completely agnostic to the direction of the z-axis, as long as depths are increasing. So

depth = [0, 300, 1000, 1100]
res = [2e14, 0.3, 1, 50, 1]

is a marine case, 300 m water layer, and a 50 Ohm.m target at 1 km depth. However, it could also be provided in the following way to empymod:

depth = [-1100, -1000, -300, 0]
res = [1, 50, 1, 0.3, 2e14]

The result is exactly the same. So empymod works for positive z downwards AND upwards, which is great news!

There are two differences to keep in mind:

  • src/rec on a boundary: It is always taken to be in the layer towards the next lower interface, which is a different one depending on z upwards or downwards. To avoid confusion, put it a little bit into the layer. In the above example, if, e.g., rec_z=+/-300, it will be taken to be in the water layer if z is positive downwards, but in the subsurface if z is positive upwards. If you set rec_z=+/-299.99 it will be in the water layer in both cases.
  • dip becomes -dip by switching from one to the other convention. azimuth remains the same. If positions are defined as [x1, x2, y1, y2, z1, z2] then it remains the same too.

@prisae prisae added docs Stuff related to the documentation examples Add to or improve the gallery and removed maintenance Maintaining status quo labels Jan 16, 2020
@prisae prisae removed this from the v2.0.0 milestone Jan 16, 2020
@prisae prisae changed the title Change z-direction Document possibilities of positive z upwards and downwards Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Stuff related to the documentation examples Add to or improve the gallery
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant