Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make copies of input parameters #73

Closed
prisae opened this issue Mar 3, 2020 · 1 comment · Fixed by #83
Closed

Make copies of input parameters #73

prisae opened this issue Mar 3, 2020 · 1 comment · Fixed by #83
Labels
enhancement New feature or request
Milestone

Comments

@prisae
Copy link
Member

prisae commented Mar 3, 2020

empymod changes some input parameters, e.g., src and rec. Example:

In [1]: from empymod import dipole 
In [2]: rec = [5000, 0, 200] 
In [3]: rec                                                                     
Out[3]: [5000, 0, 200]
In [4]: EMfield = dipole([0, 0, 200], rec, [], 1, 1, verb=0)              
In [5]: rec                                                                     
Out[5]: [array([5000.]), array([0.]), array([200.])]

Ensure that this does not happen. As this will break some code that assumed this 'behaviour', it should be put into the v2.0.0 release.

@prisae prisae added the enhancement New feature or request label Mar 3, 2020
@prisae prisae added this to the v2.0.0 milestone Mar 3, 2020
@prisae prisae mentioned this issue Mar 11, 2020
12 tasks
@prisae
Copy link
Member Author

prisae commented Mar 12, 2020

Just affects src and rec.

@prisae prisae linked a pull request Mar 12, 2020 that will close this issue
@prisae prisae closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant