Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up epmgp.py #57

Open
mmahsereci opened this issue Nov 1, 2018 · 2 comments
Open

clean up epmgp.py #57

mmahsereci opened this issue Nov 1, 2018 · 2 comments

Comments

@mmahsereci
Copy link
Contributor

mmahsereci commented Nov 1, 2018

it is not easy to read. Also we might want to move it out of the util folder

@apaleyes
Copy link
Collaborator

Moved epmgp to a more appropriate place. The code there seems to follow the paper notation very closely, so that may as well stay as it is. But for the functions this package defines we should at the very least have types and docstrings. @aaronkl would you be able to help write those docstrings?

@aaronkl
Copy link
Contributor

aaronkl commented Dec 19, 2018

sure I can do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants