Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find a place for mcmc_sampler.py #58

Closed
mmahsereci opened this issue Nov 1, 2018 · 2 comments
Closed

find a place for mcmc_sampler.py #58

mmahsereci opened this issue Nov 1, 2018 · 2 comments

Comments

@mmahsereci
Copy link
Contributor

it is currently in bayesian_optimization/util/ and 'util' is not a good place to be.
@apaleyes
Copy link
Collaborator

I suggest to put mcmc_sampler.py in emukit/samplers even though it is the only one we have so far, and epmgp.py in emukit/bayes_opt (for a lack of better place and because I have hard time classifying this file at all).

@javiergonzalezh
Copy link
Contributor

fine with me!

@apaleyes apaleyes mentioned this issue Dec 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@apaleyes @javiergonzalezh @mmahsereci