-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature(MapSingleObject): Allows to map on a single object instead of collection only #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add defensive programming on falsy and empty input - Refactor to split low level values transformation into a function. Morphism currying function is used as a router to Typed transformations, and Plain Object transformation - Add more Unit tests cases from @landr/Falcor UTs (+700UTs)
…t this to undefined when calling action function
… mapper to enable iteratee first use
@ludovicthomas This PR might interest you. I improved usability as already discussed. Tested with our Falcor implementation, it's fully backward compatible. No need for a review but I won't refuse a pass if you have some time :) |
1 similar comment
Sorry for late feedback. Nice work! Thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No breaking changes. Full backward compatible with previous versions.
Single Object Mapping
Allows to map a single object instead of collection only. The output dimension is the same as the input dimension.
To map an object, or collection before
To map an object, or collection now
Make low level and typed mappers functions iteratee first:
now it's possible to do:
map over a Low Level mapper (schema applied on plain objects)
map over a Typed mapper (schema applied on Type)
Misc
Closes Unable to use source properties aggregation along with a computing function #8