Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KNP cleaning bugs #3

Merged
merged 3 commits into from Mar 28, 2016
Merged

Fix KNP cleaning bugs #3

merged 3 commits into from Mar 28, 2016

Conversation

knshiro
Copy link
Contributor

@knshiro knshiro commented Mar 15, 2016

No description provided.

@mdymczyk
Copy link
Contributor

Looks ok but:

  1. probably needs more tests, right?
  2. since it's a public repo it would be good to document methods, I can take care of it, I will make a draft (to get up to speed with what each method is supposed to exactly do and make sure we're on the same page) and submit it for you for review

@knshiro knshiro changed the title [WIP] Fix KNP cleaning bugs Fix KNP cleaning bugs Mar 25, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+24.3%) to 79.518% when pulling c070e24 on hotfix/parsing into e8c9065 on master.

@mediavrog
Copy link

LGTM!
LGTM

👍 👎

@knshiro knshiro merged commit 4390c7e into master Mar 28, 2016
@knshiro knshiro deleted the hotfix/parsing branch March 28, 2016 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knshiro @mdymczyk @coveralls @mediavrog