-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support xjst #49
Support xjst #49
Conversation
…s by separate folders
…eysets-xml package
|
||
return this._xjstProcess(code, sourceMap).then(function (res) { | ||
res = template + res; | ||
return res; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно просто return template + res;
Нужно добавить обработку случая, когда приходит новое ядро и кидать ошибку. |
Тесты упали из-за таймаута, можно в опциях |
…mpatibility. Add corresponded tests for this case
].join(EOL); | ||
|
||
if (parsed.version === 2) { | ||
throw new Error('XJST templates can not be used with bem-core v3 i18n system'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v3 нужно убрать, т.к. i18n потом будет портировано в v2
@@ -35,6 +35,7 @@ | |||
"dependencies": { | |||
"bemhtml-compat": "0.1.2", | |||
"enb-bemxjst": "1.3.4", | |||
"enb-xjst": "enb-bem/enb-xjst#issue-63", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR влит, теперь можно зависеть от master
Исправил поломанные тесты. @blond |
Resolved #47
@blond
Please review it