Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add setting to show notebooks as expanded by default #176

Open
1 task done
Roundaround opened this issue Jan 3, 2024 · 1 comment
Open
1 task done

(feat) Add setting to show notebooks as expanded by default #176

Roundaround opened this issue Jan 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Roundaround
Copy link

Does it fit the projects scope?

  • This is relevant

Why?

It's a bit annoying to have to click into a notebook before even being able to see the notes therein. I realize this is done for performance since you currently only ever fetch notes on a per-book basis, but you could populate more useful data with the same number of requests with a bit of tweaking to the API.

Solution?

I propose a two-part solution:

  1. Add a user-preference option (simple boolean stored with the user in the DB) whether they'd like all the notes fetched alongside books and displayed on the left. This would require checking the field on the logged-in user's data and optionally calling a "getAllNotes" kind of new endpoint on the API
  2. Add a flag on the book level of whether to always show its notes. Would be visible next to the public checkbox. The UI might not even make any new API calls for this - simply have the backend return nested data for all the books where this flag is set to true.

Alternatives?

No response

Extra Context

No response

@Roundaround Roundaround added the enhancement New feature or request label Jan 3, 2024
@enchant97
Copy link
Owner

This can be implemented when offline mode is added. Currently every time you visit a book/note everything is fetched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants