Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

Debug server reload after code changes #40

Closed
sylwekb opened this issue Apr 10, 2017 · 6 comments
Closed

Debug server reload after code changes #40

sylwekb opened this issue Apr 10, 2017 · 6 comments

Comments

@sylwekb
Copy link
Contributor

sylwekb commented Apr 10, 2017

Add similar to django local dev server restart on source files changes

@tomchristie
Copy link
Member

Yup, we may do. Will also need to consider similar issues eg. Do templates and static files reload?

@tomchristie
Copy link
Member

Presumably we'd want to use livereload, as we already do with mkdocs...

https://github.com/mkdocs/mkdocs/blob/master/requirements/project.txt

Any other options? Pull requests welcome.

@tomchristie
Copy link
Member

Django's runserver plus uses watchman

http://django-extensions.readthedocs.io/en/latest/runserver_plus.html#introduction

I believe we should go with that (as livereload has a dependancy on tornado, that I'd rather avoid)

Aside: Hadn't realised that flask's lovely debugging tools are actually part of werkzeug.
We should take advantage of that.

@jpadilla
Copy link
Member

jpadilla commented Apr 17, 2017

werkzeug has two backends for reloader support, the default is stat and the other one is watchdog not watchman as far as I remember. I agree that actually bringing in werkzeug has a couple of advantages, including the reloader and debugging stuff

@tomchristie
Copy link
Member

Thanks @jpadilla! Been looking into it now.

@tomchristie
Copy link
Member

We're not leveraging all the stuff that werkzeug provides right now either...
Eg. Using werkzeug request and response objects might be something we want to do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants