Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for UNIX domain socket for MySQL #550

Closed
wojtasiq opened this issue May 9, 2023 · 0 comments · Fixed by #551
Closed

Support for UNIX domain socket for MySQL #550

wojtasiq opened this issue May 9, 2023 · 0 comments · Fixed by #551

Comments

@wojtasiq
Copy link
Contributor

wojtasiq commented May 9, 2023

Issue similar to #422, but for MySQL connection strings.

In short, unix_socketoption is not passed to the underlying aiomysql or asyncmy backends, which results in failed connection to database.

Originally described by coryvirok in #239 pull request (fixes only aiomysql backend) and later in opened another pull request #503 by ryanrasti. Credits to them!!!

Since this issue is blocking deployment to Google Cloud Run, I created a fix for both backends. Most of the work was done in #422, here I am only passing unix_socket value to create_pool function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant