Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BindingDict should support standard dict-functions #2135

Closed
3 tasks
maennel opened this issue Nov 25, 2014 · 4 comments
Closed
3 tasks

BindingDict should support standard dict-functions #2135

maennel opened this issue Nov 25, 2014 · 4 comments

Comments

@maennel
Copy link

maennel commented Nov 25, 2014

Standard dict functions should be supported by rest_framework.utils.serializer_helpers.BindingDict, like:

  • pop(<field_name>[, <default_value>])
  • get(<field_name>[, <default_value>])
  • len()

Perhaps, OrderedDict could be directly inherited from... I haven't looked at it in detail.

-Manuel

@tomchristie
Copy link
Member

tomchristie commented Nov 25, 2014

Yup, sure.

@vijay-shanker
Copy link

vijay-shanker commented Dec 1, 2014

will providing pop, get and len method on BindingDict class will solve the problem ?

vijay-shanker pushed a commit to vijay-shanker/django-rest-framework that referenced this issue Dec 1, 2014
@tomchristie tomchristie modified the milestone: 3.0.1 Release Dec 1, 2014
@tomchristie
Copy link
Member

tomchristie commented Dec 2, 2014

@vijay-shanker Thanks for your work on this - managed to find the right way around to do this. :)

@maennel
Copy link
Author

maennel commented Dec 2, 2014

Cool guys! Thanks for your efforts! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants