Fix empty pk detection in HyperlinkRelatedField.get_url #3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jslang lgtm, thanks! |
| @@ -87,6 +87,19 @@ def test_pk_representation(self): | |||
| assert representation == self.instance.pk.int | |||
|
|
|||
|
|
|||
| class TestHyperlinkedRelatedField(APISimpleTestCase): | |||
| def setUp(self): | |||
| self.instance = MockObject(pk=1, name='foo') | |||
There was a problem hiding this comment.
We can get rid of this self.instance which is not used in this test case.
jslang
force-pushed
the
fix_null_check_in_hyperlinkrelation
branch
from
125334d
to
186c0e3
Compare
This implementation allows detection of empty values that are non-nullable, allowing the field to return None values for such cases
jslang
force-pushed
the
fix_null_check_in_hyperlinkrelation
branch
from
186c0e3
to
7ac8cc7
Compare
|
Looks good to me too. |
tomchristie
added a commit
that referenced
this pull request
Mar 4, 2016
Fix empty pk detection in HyperlinkRelatedField.get_url
|
Thanks! |
xordoquy
added a commit
to linovia/django-rest-framework
that referenced
this pull request
Mar 7, 2016
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation allows detection of empty values that are non-nullable, allowing the field to return
Nonevalues for such cases. Fixes #3959