type('') to str #4025
Merged
type('') to str #4025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems ok to me. |
|
This will not work on both Python 2.x and 3.x. |
dnit
force-pushed
the
master
branch
2 times, most recently
from
0e39cb6
to
c22b92a
Compare
| @@ -19,7 +20,7 @@ def get_authorization_header(request): | |||
| Hide some test client ickyness where the header can be unicode. | |||
| """ | |||
| auth = request.META.get('HTTP_AUTHORIZATION', b'') | |||
| if isinstance(auth, type('')): | |||
There was a problem hiding this comment.
I believe we've just changed the meaning here. string_types includes both binary and unicode. type('') with from __future__ import unicode_literals will always only be unicode.
I think we should probably have if isinstance(auth, text_type), to preserve the meaning, as the intent is to encode unicode into bytestrings.
There was a problem hiding this comment.
Good catch. Will correct that today.
xordoquy
added a commit
to linovia/django-rest-framework
that referenced
this pull request
Apr 5, 2016
tomchristie
pushed a commit
that referenced
this pull request
Apr 7, 2016
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing type('') to str