New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Correct schema parsing for JSONField #5878
Conversation
This fixes #5873.
Hi @beruic. Can you add a regression test for this too please? Thanks. |
Well, I would like to, but this is new ground for me, time is sparse, and i already spend a lot of time tracking this down. I have tested this informally, and now I have looked at how to write a test for this for about an hour, and I cannot figure out how to test this. Perhaps there should just be made an issue to test If it really is the case that none of the other output of |
The test coverage here is sub-optimal. All the schema related code is still quite new and so this is to be expected. As we make changes we want to add coverage. We try not to add changes without a regression test to make sure future changes don't break anything. A test on Thanks for the effort! |
I have added tests now, testing JSONField and the simple cases of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. This looks good. Thanks @beruic.
Fixes encode#5873. * Use Object type. * Add test for field_to_schema
This fixes #5873.