Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Django 1.11 support #6230

Closed
tomchristie opened this issue Oct 3, 2018 · 8 comments
Closed

Drop Django 1.11 support #6230

tomchristie opened this issue Oct 3, 2018 · 8 comments

Comments

@tomchristie
Copy link
Member

Once 3.9 has been released I think we probably ought to drop our support for Django 1.11 and Python 2.7. We can start by dropping these from master, and then have our 3.10 release be the first to only support Python 3 onwards.

@rpkilby
Copy link
Member

rpkilby commented Oct 3, 2018

Should we drop Python 2 but otherwise support Django 1.11 until the next LTS is released?

@auvipy
Copy link
Member

auvipy commented Oct 5, 2018

Dropping support of python 2 after 3.9 release and waiting for dropping django 1.11 after the release of django 2.2 alpha at least? I would like to volunteer to drop python 2 support if needed.

@johnthagen
Copy link
Contributor

In the meantime, I was surprised given that Python 2 is so close to EOL that places in the docs are still Python-2 first.

https://www.django-rest-framework.org/api-guide/relations/#inspecting-relationships

>>> print repr(serializer)  # Or print(repr(serializer)) in Python 3.x.

Shouldn't these be instead:

>>> print(repr(serializer))  # Or `print repr(serializer)` in Python 2.x.

Though, actually in Python 2.7, both are valid, so perhaps at least this example should just be:

>>> print(repr(serializer))

@xordoquy
Copy link
Collaborator

Unfortunately some will have gone under our radars.

@rpkilby
Copy link
Member

rpkilby commented Mar 26, 2019

Note that we can now drop Python 3.4 as well, which just went EOL on the 18th.

edit: we probably should drop Python 3.4, since pip is giving warnings about its support.

@webbyfox
Copy link
Contributor

I did manage to fix test issue at #6591 which is a fix for #6277 from @auvipy

@auvipy
Copy link
Member

auvipy commented Apr 30, 2019

@carltongibson IMHO the title should be changed to Python 2.7 and 3.4 drops.... not Django 1.11 before 3.0 release at least.

@rpkilby rpkilby changed the title Dropping Django 1.11 and Python 2.7 support. Drop Django 1.11 support May 30, 2019
@rpkilby rpkilby removed this from the 3.10 Release milestone May 30, 2019
@rpkilby
Copy link
Member

rpkilby commented May 30, 2019

Removing from the milestone, since we've already dropped Python 2 support, and I don't think we want to drop Django 1.11 until Django 3.0 is released.

@rpkilby rpkilby added this to the 3.11 Release milestone Jul 2, 2019
@rpkilby rpkilby modified the milestones: 3.11 Release, 3.12 Release Dec 6, 2019
@rpkilby rpkilby removed this from the 3.12 Release milestone Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants