Fix CursorPagination parameter schema type #7708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
any reasons to not merge this fix ? |
The CursorPagination's cursor query parameter expects a string and not an integer. Fixes encode#7691
|
Just waiting for attention from a maintainer, I think 😞. |
|
@tomchristie , is anything blocking here ? |
|
Yes, makes sense - thanks! |
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
The CursorPagination's cursor query parameter expects a string and not an integer. Fixes encode#7691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CursorPagination's cursor query parameter expects a string and not
an integer.
This fixes issues where a valid cursor is rejected due to an incompatible type in the schema.
refs #7691