Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python/Django compatibility updates #8288

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

pauloxnet
Copy link
Contributor

@pauloxnet pauloxnet commented Dec 10, 2021

Changes

  • Update python and django versions in tox.ini
  • Update python requires in setup.py

@pauloxnet pauloxnet changed the title Python 3.10 related updates Python/Django compatibility updates Dec 10, 2021
@pauloxnet pauloxnet mentioned this pull request Dec 10, 2021
tox.ini Outdated
django22: Django>=2.2,<3.0
django31: Django>=3.1,<3.2
django32: Django>=3.2,<4.0
django40: Django>=4.0,<5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we really want to change these.
(Or at least we could consider if we do or not independently of the rest of this PR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I've reported the minimum versions of Django for each major version that are compatible with the python/django matrix (e.g. Django 3.2 is compatible with Python 3.10 starting from 3.2.9).

If you think it's an added value to the tox.ini file I can open a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think I see. I wasn't able to find out what ~= meant.
In any case, in practice the existing version is absolutely fine.

tox.ini Outdated Show resolved Hide resolved
@tomchristie tomchristie merged commit 773f479 into encode:master Dec 10, 2021
sk1p added a commit to sk1p/django-rest-framework that referenced this pull request Dec 13, 2021
Just a left-over from encode#8288 to sync the "Unsupported Python version" message with `python_requires`.
tomchristie pushed a commit that referenced this pull request Dec 13, 2021
Just a left-over from #8288 to sync the "Unsupported Python version" message with `python_requires`.
@ofek
Copy link

ofek commented Aug 24, 2022

On https://pypi.org/project/Django/2.2.28/#files looking inside the sdist shows 3.5 support. How does DRF determine its minimum supported Python version?

sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
* Update python and django versions in tox.ini

* Update  python requires in setup.py

* Update tox.ini

Co-authored-by: Tom Christie <tom@tomchristie.com>
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Just a left-over from encode#8288 to sync the "Unsupported Python version" message with `python_requires`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants