-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python/Django compatibility updates #8288
Conversation
70a6963
to
7934b47
Compare
tox.ini
Outdated
django22: Django>=2.2,<3.0 | ||
django31: Django>=3.1,<3.2 | ||
django32: Django>=3.2,<4.0 | ||
django40: Django>=4.0,<5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we really want to change these.
(Or at least we could consider if we do or not independently of the rest of this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I've reported the minimum versions of Django for each major version that are compatible with the python/django matrix (e.g. Django 3.2 is compatible with Python 3.10 starting from 3.2.9).
If you think it's an added value to the tox.ini
file I can open a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think I see. I wasn't able to find out what ~=
meant.
In any case, in practice the existing version is absolutely fine.
Just a left-over from encode#8288 to sync the "Unsupported Python version" message with `python_requires`.
Just a left-over from #8288 to sync the "Unsupported Python version" message with `python_requires`.
On https://pypi.org/project/Django/2.2.28/#files looking inside the sdist shows 3.5 support. How does DRF determine its minimum supported Python version? |
* Update python and django versions in tox.ini * Update python requires in setup.py * Update tox.ini Co-authored-by: Tom Christie <tom@tomchristie.com>
Just a left-over from encode#8288 to sync the "Unsupported Python version" message with `python_requires`.
Changes