Fix api_view decorator with Django 4 #8291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using Django 4, we get slightly unexpected behaviour using the
api_view
decorator:Further Discussion
This change is caused by a change in the way that Django 4 implements
View.as_view()
. The change and a full discussion can be viewed here, but in short:as_view
used to useupdate_wrapper
and now it doesn't.I was definitely for the change above, and argued against using
update_wrapper
in that case, but for a decorator such asapi_view
it is definitely appropriate, and I would expect things like__name__
and__qualname__
to be preserved from the original function.When using a class-based view you have written, using
view_class
seems a reasonable approach. But in this case, the fact you have a class-based view is obscured unless you read the source code and so I think__name__
should be copied over.