New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local test server #109
Comments
I raised the same concern some time ago on our Gitter channel. I’d also like to move to a local server setup but I've seen some push back - the main benefit of these live server tests being that indeed we test against some random live HTTP/1.1 / HTTP/2 implementation. It’s a valid point but for me there is also real value in being able to run tests fast and offline. Not against having E2E tests against a live server out there, but we could reduce their number (or not?) and at least separate them from the rest and skip them in case we detect we’re offline. An I also 100% agree that E2E tests only greatly reduces our ability and ease of testing against weird edge cases (though it’s not incompatible - we can definitely just decide to add more integration tests eg against Hypercorn with various configs). |
Totally up for having a One possible awkwardness might be if hypercorn supports a different range of Python versions to us, but otherwise I don't have any problem whatsoever with us preferring it over uvicorn. |
Our test suite performs real internet connections. This has worked well for us since it gives us full confidence that httpcore works in real circumstances. However it has some drawbacks:
In HTTPX we use a local test server based on Uvicorn which has worked well, the only drawback that I'm aware it's the lack of HTTP/2 support.
Should we go for the same approach here?
Related #108
The text was updated successfully, but these errors were encountered: