Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping upper pin on h11 #509

Closed
zanieb opened this issue Feb 18, 2022 · 9 comments
Closed

Consider dropping upper pin on h11 #509

zanieb opened this issue Feb 18, 2022 · 9 comments

Comments

@zanieb
Copy link
Contributor

zanieb commented Feb 18, 2022

Hi! By pinning the upper version of h11 in setup.py each time they make a release projects that depend on httpcore can fail with version requirement issues.

For example:

ERROR: httpcore 0.14.7 has requirement h11<0.13,>=0.11, but you'll have h11 0.13.0 which is incompatible.
...
pkg_resources.ContextualVersionConflict: (h11 0.13.0 (/.../python3.8/lib/python3.8/site-packages), Requirement.parse('h11<0.13,>=0.11'), {'httpcore'})

Could you remove the upper pin and allow consumers of this important library to use compatible versions on release or restrict the version themselves if necessary?

Of course, part of this is pip's fault as it should be resolving these constraints, but it does not appear to do so consistently.

A discussion of upper bounds: https://iscinumpy.dev/post/bound-version-constraints/

Related to: #503

This could be extended to all of the versioning in the setup.py which mostly pin to major versions.

@tomchristie
Copy link
Member

tomchristie commented Feb 21, 2022

I think that'd probably be okay.

As you can see from #503 we've a couple of changes we'd need to make to ensure our tests still pass. (Not because the behaviour is wrong, just because it's structured in a way that it fails type checking against the newly added annotations.)

The block to this is probably having someone work on resolving that.

@stale
Copy link

stale bot commented Mar 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 25, 2022
@zanieb
Copy link
Contributor Author

zanieb commented Mar 25, 2022

Hi bot, this issue is still relevant. The upper pin remains and furthermore httpcore is not compatible with h11 0.13+.

@stale stale bot removed the wontfix This will not be worked on label Mar 25, 2022
@stale
Copy link

stale bot commented Apr 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 25, 2022
@zanieb
Copy link
Contributor Author

zanieb commented Apr 25, 2022

A decision is still needed on #526 to support h11 0.13.

@stale stale bot removed the wontfix This will not be worked on label Apr 25, 2022
@stale
Copy link

stale bot commented May 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 31, 2022
@tomchristie
Copy link
Member

Boop. #549

@stale stale bot removed the wontfix This will not be worked on label May 31, 2022
@graingert
Copy link
Member

A decision is still needed on #526 to support h11 0.13.

The decision is about PAUSED handling? If so that's resolved

@tomchristie
Copy link
Member

Right, let's consider #579 as resolving this.
We'll keep the pinning (because, we're careful like that) but we've bumped up the version to the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants