New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider dropping upper pin on h11 #509
Comments
I think that'd probably be okay. As you can see from #503 we've a couple of changes we'd need to make to ensure our tests still pass. (Not because the behaviour is wrong, just because it's structured in a way that it fails type checking against the newly added annotations.) The block to this is probably having someone work on resolving that. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi bot, this issue is still relevant. The upper pin remains and furthermore httpcore is not compatible with h11 0.13+. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
A decision is still needed on #526 to support h11 0.13. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Boop. #549 |
The decision is about PAUSED handling? If so that's resolved |
Right, let's consider #579 as resolving this. |
Hi! By pinning the upper version of h11 in
setup.py
each time they make a release projects that depend onhttpcore
can fail with version requirement issues.For example:
Could you remove the upper pin and allow consumers of this important library to use compatible versions on release or restrict the version themselves if necessary?
Of course, part of this is
pip
's fault as it should be resolving these constraints, but it does not appear to do so consistently.A discussion of upper bounds: https://iscinumpy.dev/post/bound-version-constraints/
Related to: #503
This could be extended to all of the versioning in the
setup.py
which mostly pin to major versions.The text was updated successfully, but these errors were encountered: