Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: provide suport for rfc3986 2.0.0 #2169

Closed
kloczek opened this issue Apr 7, 2022 · 1 comment · Fixed by #2252
Closed

RFE: provide suport for rfc3986 2.0.0 #2169

kloczek opened this issue Apr 7, 2022 · 1 comment · Fixed by #2252
Labels
external Root cause pending resolution in an external dependency

Comments

@kloczek
Copy link

kloczek commented Apr 7, 2022 •
edited
Loading

Currently rfc3986 2.0.0 is not supported.

httpx/setup.py

Lines 58 to 62 in 3af5146

install_requires=[
"certifi",
"charset_normalizer",
"sniffio",
"rfc3986[idna2008]>=1.3,<2",

Do you have any plans to provide such support?
@tomchristie
Copy link
Member

Bumping up to the latest version of rfc3986 issues some deprecation warnings.

After some digging I can see that those are caused internally by rfc3986. We're using .resolve_with(), which isn't deprecated, but which is itself raising some issues. See here... python-hyper/rfc3986#86

@tomchristie tomchristie added the external Root cause pending resolution in an external dependency label May 6, 2022
@jd jd mentioned this issue May 10, 2022
Closed
@tomchristie tomchristie mentioned this issue Jun 1, 2022
Merged
@dalf dalf mentioned this issue Jun 2, 2022
Closed
@tomchristie tomchristie mentioned this issue Jun 20, 2022
Closed
@jodal jodal mentioned this issue Oct 4, 2022
Closed
@ignition-ctrl ignition-ctrl mentioned this issue Oct 12, 2022
Closed
@sgn sgn mentioned this issue Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external Root cause pending resolution in an external dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop rfc3986 requirement. encode/httpx
2 participants
@tomchristie @kloczek