Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use '%20' for encoding spaces in query parameters. #2543

Merged
merged 5 commits into from Jan 10, 2023
Merged

Use '%20' for encoding spaces in query parameters. #2543

merged 5 commits into from Jan 10, 2023

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Jan 5, 2023 •
edited

Query parameter encoding switches from using + for spaces and %2F for forward slash, to instead using %20 for spaces and treating forward slash as a safe, unescaped character.

Closes #2536.

  • Add failing test.
  • Fix behaviour.

@tomchristie tomchristie added the user-experience Ensuring that users have a good experience using the library label Jan 5, 2023
@tomchristie tomchristie marked this pull request as ready for review January 5, 2023 10:44
@tomchristie tomchristie requested a review from a team January 10, 2023 10:48
@tomchristie tomchristie merged commit a6af45e into master Jan 10, 2023
@tomchristie tomchristie deleted the percent-encoding-spaces branch January 10, 2023 11:16
@tomchristie tomchristie mentioned this pull request Apr 6, 2023
Merged
@marban marban mentioned this pull request Apr 16, 2023
Closed
@rslinckx rslinckx mentioned this pull request Apr 19, 2023
Closed
@marban marban mentioned this pull request May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
user-experience Ensuring that users have a good experience using the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use percent encoding for spaces in query parameters
2 participants
@tomchristie @aminalaee