Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix third party package documentation link #2902

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Fix third party package documentation link #2902

merged 3 commits into from
Oct 31, 2023

Conversation

karpetrosyan
Copy link
Member

No description provided.

@tomchristie
Copy link
Member

Should we typically approve-and-then-merge on PRs, or approve-and-then-allow-op-to-merge?

@zanieb
Copy link
Contributor

zanieb commented Oct 30, 2023

Probably best practice for op to merge, but as the lead of the project I think you can merge whenever you want :)

@karpetrosyan karpetrosyan merged commit 5f2d620 into encode:master Oct 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karpetrosyan @tomchristie @zanieb