-
-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix httpcore>=0.17.2
for lastest httpx version
#2934
Comments
From the discussion... I think the version requirement here should be |
I would also prefer to set |
It's okay for us to be slightly overly restrictive here, there's no reason we shouldn't force a 1.* minimum version. |
Okay understood ! |
Closed via #2937 |
@tomchristie this fix probably needs a release, people are getting errors due to the lack of restriction in 0.25.1: ramnes/notion-sdk-py#213 |
Discussed #2930
It seems the latest httpx version aris not compatible with all
httpcore
version. But in the pyproject.toml thehttpcore
version is not bounded.After testing, it seems that the minimal compatible version of
httpcore
with httpx>=0.25.1 is0.17.2
.What do you think ?
The text was updated successfully, but these errors were encountered: