Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix httpcore>=0.17.2 for lastest httpx version #2934

Closed
wenceslas-sanchez opened this issue Nov 9, 2023 · 6 comments
Closed

Fix httpcore>=0.17.2 for lastest httpx version #2934

wenceslas-sanchez opened this issue Nov 9, 2023 · 6 comments

Comments

@wenceslas-sanchez
Copy link
Contributor

Discussed #2930

It seems the latest httpx version aris not compatible with all httpcore version. But in the pyproject.toml the httpcore version is not bounded.

After testing, it seems that the minimal compatible version of httpcore with httpx>=0.25.1 is 0.17.2.

What do you think ?

@tomchristie
Copy link
Member

From the discussion... I think the version requirement here should be httpcore==1.*.

@wenceslas-sanchez
Copy link
Contributor Author

I would also prefer to set 1.* but isn't it too restrictive since some older versions of botocore are also compatible ?

@tomchristie
Copy link
Member

It's okay for us to be slightly overly restrictive here, there's no reason we shouldn't force a 1.* minimum version.

@wenceslas-sanchez
Copy link
Contributor Author

Okay understood !

@tomchristie
Copy link
Member

Closed via #2937

@ramnes
Copy link

ramnes commented Nov 22, 2023

@tomchristie this fix probably needs a release, people are getting errors due to the lack of restriction in 0.25.1: ramnes/notion-sdk-py#213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants