Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URLs where username or password contains unescaped '@'. #2985

Closed
tomchristie opened this issue Dec 6, 2023 Discussed in #2984 · 0 comments · Fixed by #2986
Closed

Allow URLs where username or password contains unescaped '@'. #2985

tomchristie opened this issue Dec 6, 2023 Discussed in #2984 · 0 comments · Fixed by #2986
Labels
bug Something isn't working

Comments

@tomchristie
Copy link
Member

Discussed in #2984

We don't gracefully handle the case where a @ character is present and unescaped in a URL userinfo/authority section.
I've confirmed that this is a valid issue, and reduced it down to demonstrating against the httpx.URL() API.

Tested the behaviour for Chrome's URL parsing behaviour using username/password against example.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant