Accessing the query parameter of URL throws an Unhashable Type error

[jarviliam]

EDIT: Sorry, looking into this a bit more I realized the below case would not happen because

starlette/starlette/datastructures.py

Line 59 in ada845c

url = URL("").replace(**components).components.geturl()

returns a string not a URL 🙏 .

I recently bumped FastAPI to 0.95 which also bumped starlette to 0.26.0 and I noticed something that may be an issue. Before the update we created a URL like this:

url = URL(
        path.make_absolute_url(
            base_url="www.test.com"
        )
    ).include_query_params(**query_params)

and calling the include_query_params function now throws a URL Unhashable type due to this change: https://github.com/encode/starlette/pull/1385/files.
The issue is fixed by simply changing it to:

url =  path.make_absolute_url(
            base_url="www.test.com"
        ).include_query_params(**query_params)

as it now returns a URL and not a string.

Looking at the init of URL

starlette/starlette/datastructures.py

Lines 57 to 61 in ada845c

	elif components:
	assert not url, 'Cannot set both "url" and "**components".'
	url = URL("").replace(**components).components.geturl()
	self._url = url

I can see theres a condition for elif components where self._url becomes a URL type and not a string.
I'm pretty sure in this situation the Unhashable Type error would also occur.
Just wanted to make sure this is intended or not.