Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apitally to third party packages section in docs #2313

Merged
merged 6 commits into from
Nov 4, 2023
Merged

Add Apitally to third party packages section in docs #2313

merged 6 commits into from
Nov 4, 2023

Conversation

itssimon
Copy link
Contributor

@itssimon itssimon commented Oct 29, 2023

Summary

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@itssimon itssimon changed the title Add ApitallyMiddleware to third party middleware section in docs Add Apitally to third party packages section in docs Oct 30, 2023
@Kludex
Copy link
Sponsor Member

Kludex commented Oct 30, 2023

I think the third party packages is enough... No need for the middleware...

@itssimon
Copy link
Contributor Author

Fair call. Done.

@Kludex
Copy link
Sponsor Member

Kludex commented Nov 3, 2023

Is this going to be the first commercial product included in this section?

Does it sound fair to you to promote your product without you even sponsoring the organization?

@itssimon
Copy link
Contributor Author

itssimon commented Nov 4, 2023

I genuinely believe that this will add value to the community, despite being a commercial product.

There are a few other commercial products linked in the Third party middleware section of the docs (e.g. Bugsnag, Rollbar).

Given Apitally is built with FastAPI, and hence Starlette, I do think sponsorship would be fair regardless of this mention in the docs. I will definitely consider it once Apitally is profitable!

@Kludex Kludex merged commit 1373910 into encode:master Nov 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants