Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session cookie should use root path #233

Closed
tomchristie opened this issue Nov 22, 2018 · 0 comments · Fixed by #1147
Closed

Session cookie should use root path #233

tomchristie opened this issue Nov 22, 2018 · 0 comments · Fixed by #1147
Labels
clean up Refinement to existing functionality

Comments

@tomchristie
Copy link
Member

The session cookie currently uses '/'.
It should really use the ASGI root path instead, in case the application is submounted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clean up Refinement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make session cookie use ASGI root path mahmoudhossam/starlette
1 participant
@tomchristie