Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade mkdocs-material #2439

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Downgrade mkdocs-material #2439

merged 2 commits into from
Jan 23, 2024

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Jan 23, 2024

@Kludex Kludex requested a review from a team January 23, 2024 07:17
@Kludex
Copy link
Sponsor Member Author

Kludex commented Jan 23, 2024

@encode/maintainers I need this to be approved. The docs are not working.

Copy link
Member

@frankie567 frankie567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚒👍

@Kludex Kludex merged commit 4ca0a87 into master Jan 23, 2024
5 checks passed
@Kludex Kludex deleted the fix-docs branch January 23, 2024 08:29
@MtkN1
Copy link

MtkN1 commented Jan 24, 2024

@Kludex Thank you for the fix! By the way, the same issue is occurring in encode/uvicorn docs as well.
https://www.uvicorn.org/

@Kludex
Copy link
Sponsor Member Author

Kludex commented Jan 24, 2024

Oh my god! 😢

@tomchristie
Copy link
Member

the same issue is occurring in encode/uvicorn docs as well.

Hmmm... what's that about?

@Kludex
Copy link
Sponsor Member Author

Kludex commented Jan 24, 2024

the same issue is occurring in encode/uvicorn docs as well.

Hmmm... what's that about?

We need to downgrade the mkdocs-material there as well, and publish the docs. I didn't have time yet.

nixroxursox pushed a commit to nixroxursox/starlette that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants