Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to test_error.py #2462

Merged
merged 4 commits into from Feb 4, 2024

Conversation

TechNiick
Copy link
Contributor

Summary

Related to this PR
Type annotation added to test_errors.py

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the others.

tests/middleware/test_errors.py Outdated Show resolved Hide resolved
tests/middleware/test_errors.py Outdated Show resolved Hide resolved
tests/middleware/test_errors.py Outdated Show resolved Hide resolved
tests/middleware/test_errors.py Outdated Show resolved Hide resolved
tests/middleware/test_errors.py Outdated Show resolved Hide resolved
tests/middleware/test_errors.py Outdated Show resolved Hide resolved
tests/middleware/test_errors.py Outdated Show resolved Hide resolved
@Kludex Kludex enabled auto-merge (squash) February 4, 2024 20:53
@Kludex Kludex merged commit c158ef4 into encode:master Feb 4, 2024
5 checks passed
@TechNiick TechNiick changed the title Added type annotations to test_error.py Added type hints to test_error.py Feb 4, 2024
@TechNiick TechNiick changed the title Added type hints to test_error.py Add type hints to test_error.py Feb 6, 2024
nixroxursox pushed a commit to nixroxursox/starlette that referenced this pull request Mar 18, 2024
* added type annotations to test_error.py

* Apply suggestions from code review

---------

Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants