Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop asgiref dependency at all #1999

Merged
merged 3 commits into from Jun 8, 2023
Merged

Drop asgiref dependency at all #1999

merged 3 commits into from Jun 8, 2023

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Jun 8, 2023 •
edited

@Kludex Kludex requested a review from a team June 8, 2023 06:34
zanieb
zanieb reviewed Jun 8, 2023
View reviewed changes
uvicorn/_types.py Outdated
# ASGI


__all__ = (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be at the top and include the WSGI types?

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be removed. Good catch

@Kludex Kludex requested a review from zanieb June 8, 2023 08:04
@Kludex Kludex requested a review from a team June 8, 2023 10:37
@Kludex Kludex merged commit 1cb58c7 into master Jun 8, 2023
15 checks passed
@Kludex Kludex deleted the burn/drop-asgiref branch June 8, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create own types instead of using asgiref
2 participants
@Kludex @zanieb