Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support websocket upgrades from h11 implementation #90

Closed
tomchristie opened this issue Jun 29, 2018 · 0 comments
Closed

Support websocket upgrades from h11 implementation #90

tomchristie opened this issue Jun 29, 2018 · 0 comments
Labels
help wanted

Comments

@tomchristie
Copy link
Member

tomchristie commented Jun 29, 2018 •
edited

The httptools implementation (default) supports websockets upgrades, but the h11 implementation doesn't yet.

Add this support, and then ensure that the websocket tests run against both protocol classes.
@tomchristie tomchristie changed the title Support websocket upgrades from h11 implementation. Support websocket upgrades from h11 implementation Jun 29, 2018
@jordaneremieff jordaneremieff mentioned this issue Jul 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomchristie