modify the if statment which check if center[i] at the boundary of th… #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you I will look at this soon for the next release of Encog. |
|
Agree with this change, thanks! Will add to C# too. |
jeffheaton
pushed a commit
to jeffheaton/encog-dotnet-core
that referenced
this pull request
Sep 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify the if statment which check if center[i] at the boundary of the neuron mesh
the boundary of the neuron mesh is minPosition and maxPosition, two parameters of "setRBFCentersAndWidthsEqualSpacing" method, right?
They may have various values, though typically 0 and 1. For example in the constructor "public RBFNetwork(final int inputCount, final int hiddenCount, final int outputCount, final RBFEnum t)", setRBFCentersAndWidthsEqualSpacing method is called with patameters minPosition = -1 and maxPosition = 1
so, I think the boundary check should be like this:
if ((centers[i][z] == minPosition) || (centers[i][z] == maxPosition))