Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move interactive commands to the repl crate #130

Open
jmmv opened this issue Oct 28, 2021 · 0 comments
Open

Move interactive commands to the repl crate #130

jmmv opened this issue Oct 28, 2021 · 0 comments
Labels
refactoring Internal changes that are not user visible enhancements

Comments

@jmmv
Copy link
Collaborator

jmmv commented Oct 28, 2021

This is a follow up to #118. The std crate currently has various commands that are meant to be used from an interactive context only, like LOAD and SAVE, and it even has a concept of a InteractiveMachineBuilder. I sense that all of these belong in the repl crate.

One might argue that a program should be able to use LOAD, for example, to run a different program -- but that wouldn't work because, as soon as it did that, it'd lose control of what it is doing. So the answer here is that those programs should use RUN as described in #129. Need to review if there are other corner cases like that.

@jmmv jmmv added the refactoring Internal changes that are not user visible enhancements label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal changes that are not user visible enhancements
Projects
None yet
Development

No branches or pull requests

1 participant