Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea] Use Collections instead of default arrays #5

Closed
NoelDavies opened this issue Oct 23, 2019 · 2 comments
Closed

[Idea] Use Collections instead of default arrays #5

NoelDavies opened this issue Oct 23, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@NoelDavies
Copy link

I know that it requires another dependency, but what is people's thoughts on using Collections over vanilla arrays for a lot of what's being used currently.

I personally think it would make things a lot cleaner and easier to read, use and understand.

@bvisness
Copy link

If you're referring to https://www.php.net/manual/en/class.ds-collection.php, then that would require everybody to install the ds extension, which would definitely be a breaking change. It would be wiser to stick with vanilla arrays so more people can actually use this library.

@NoelDavies
Copy link
Author

NoelDavies commented Oct 24, 2019

I was referring to the tightenco/collection library - https://github.com/tightenco/collect

@NoelDavies NoelDavies added the enhancement New feature or request label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants