-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to inject Redis client in redis storage #7
Comments
I'm down for that if others are open to it - the only thing is it's a huge method signature change and would not be backwards compat. So we'd have to solve this in one of the following ways (open to others, these are just the ideas I can see):
|
I personally like the names constructor option. Let me try it out and I'll send some code your way when I have something to show. |
Just noticed that I see two options here:
WDYT? |
Here is a draft PR: #8 |
The existing connection would still have to be injected, but nice find! |
Closed by #8 |
Rigth now
\Redis
client is constructed within__construct
method ofPrometheus\Storage\Redis
class. What thoughts do you have on adding ability to inject\Redis
into storage class? This would allow to reuse already existing connection from framework.I'm happy to contribute the code change if/when it's decided to do it and what would be the best approach to do it.
The text was updated successfully, but these errors were encountered: