Update api-consumer.jsx #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamically adapt the PORT URL to support network access of file uploading.
|
|
|
We were just talking about a good way to fix this. Thanks. I hope you can sign our CLA! |
|
Glad to help, sorry for the CLA! |
|
just tested it out and it works well. thanks! I may soon add a warning about running the xori gui on networks being "at your own risk". I imagine most users would be well aware, but you never know who might try it and be surprised at strangers disassembling things on their machine, or worse trying to exploit the js servers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the webUI is accessible via the network hardcoding 'localhost' returns errors when uploading from another machine. Substituting "localhost' with 'window.location.hostname' dynamically changes the POST URL path to adjust and remain functional from other machines on the Network. In my case Xori can now be used on a centralized server that is shared between team members.