Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support show Annotation on pdf #102

Closed
mouxhun opened this issue Sep 15, 2020 · 12 comments · Fixed by #103
Closed

Support show Annotation on pdf #102

mouxhun opened this issue Sep 15, 2020 · 12 comments · Fixed by #103

Comments

@mouxhun
Copy link
Contributor

mouxhun commented Sep 15, 2020

on android, is there a way to support show annotation on pdf
maybe give an option or just enable pdfView.enableAnnotationRendering(true) directly?

@mouxhun
Copy link
Contributor Author

mouxhun commented Sep 15, 2020

ios does not have this problem, it show annotation correctly

@endigo
Copy link
Owner

endigo commented Sep 15, 2020

@mouxhun Hey, can you make the change that contains your needs, and create PR?

@mouxhun
Copy link
Contributor Author

mouxhun commented Sep 15, 2020

With pleasure

@endigo
Copy link
Owner

endigo commented Sep 15, 2020

@mouxhun release in 1.0.3+4. Thanks

@mouxhun
Copy link
Contributor Author

mouxhun commented Sep 15, 2020

You're welcome

@sahmirzali
Copy link

@endigo @mouxhun How can i enable annotation ? could you help please ?

@endigo
Copy link
Owner

endigo commented Oct 2, 2020

@sahmirzali If you use the v1.0.3+4 and up, it is enabled by default.

@sahmirzali
Copy link

@endigo i load pdf from asset. i can't select any text. but i'm sure text is selectable in pdf. i checked

@endigo
Copy link
Owner

endigo commented Oct 2, 2020

@sahmirzali annotation means an extra layer over the text layer. https://github.com/barteksc/AndroidPdfViewer maybe did not support text selection or I didn't enable it. If you find the issue, you could create new PR.

@sahmirzali
Copy link

sahmirzali commented Oct 2, 2020

I'm sorry for question :) . I want to know this package isn't support selection text ?

@endigo
Copy link
Owner

endigo commented Oct 2, 2020

According to this issue, DImuthuUpe/AndroidPdfViewer#95 text selection not supported by the native plugin

@sahmirzali
Copy link

thanks for repy my question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants