Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openURL first deprecated in iOS 10 #155

Open
dmitry-grin opened this issue Oct 11, 2021 · 1 comment
Open

openURL first deprecated in iOS 10 #155

dmitry-grin opened this issue Oct 11, 2021 · 1 comment

Comments

@dmitry-grin
Copy link

Hey guys,

since you support minimum iOS version 11

Consider changing following to reduce potential side effect

[[UIApplication sharedApplication] openURL:url];

to

UIApplication *application = [UIApplication sharedApplication];

[application openURL:url options:@{} completionHandler:^(BOOL success) {
    //provide callback ?
    if (success) {
         NSLog(@"Opened url");
    }
}];

if you don't have time or resource for that, I can send you a pull request, thanks

APPLE DOCS

Снимок экрана 2021-10-11 в 18 35 45

@myselfuser1
Copy link

This will help https://www.youtube.com/watch?v=gAUVz0U7eyA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants