-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purchase "Search functionality" feature possible? #179
Comments
Unfortunately there is no answer to my question since three months. In case anyone is in the same situation: What I did is the following:
This is not optimal yet, but at least a beginning. A big "thank you" goes to @Taron133 for implementing the string extraction feature. Highlighting the found text in the PDFViewer would be nice now, which - to my understanding - is not yet implemented. Reading the documentation of PDFKit (iOS only) though, it appears to be possible to add this, compare https://www.pdftron.com/blog/ios/how-to-add-annotations-using-swift-and-pdfkit/ Since I have never worked with the swift programming language I will need some time to get my head around this, but it doesnt seem to be very difficult. If I will manage to implement highlighting, I will post my solution here as well. Kind regards, |
Working with PDF is hard, if you look at the AppStore, PDF applications are often on the top most downloaded apps. In this plugin case, it creates a UiKitView which is still alpha on Flutter. Yes PDFKit provides by default search but it does not guarantees if it would work properly on UiKitView. I think best dev XP would be to develop a renderer in pure Dart but it would literally take years (full-time). With my co-worker we've been there working with PDFs and the spec is just too big. That's basically why there are still proprietary APIs in this field. |
Screen.Recording.2023-03-29.at.10.42.23.movI've added for iOS, let me know what you guys think @endigo |
Thank you @mirkancal for your great work! This looks awesome. Due to time restrictions I had to move from flutter_pdfview to syncfusion_pdf (https://pub.dev/packages/syncfusion_flutter_pdf). I will therefore close this issue. Kind regards, |
@mirkancal Hey bro, nice work out there, did you by any chance make a solution to jump to a specific page when searching the text? |
@mvukojicic It's jumping to page but when there are lot of results from the same search keywords, it's pretty slow and freezes. I need to convert search results to stream or something. Also I couldn't find anything for Android. That's swift version, code is easier to understand alhappler/alh_pdf_view#38 |
@mirkancal Can you please point me to the part of the code and logic for jumping to searched words? |
@mvukojicic it's Line highlighted URLs: mirkancal@49638d9#diff-494acf6b42388364aaee89f58f98b07e7daa1fe9a20eef4b723553b8d216baefR304-R311 |
@mirkancal bro you are the king, thank you so much! |
Hi @endigo,
Thank you for the awesome flutter plugin, it works like a charm in my iOS simulator (couldn't test it on a real device yet, hope I will not have the same issue like a few other users).
I am currently developing an app for a client and presented him the first prototype draft which uses your PDF API. The client asked me if it is possible to search for keywords in the pdf view so that these get highlighted (similar to how it works in Adobe Acrobat Reader when you press "CTRL + F"). I see that this feature is on your Future Plans list.
My question is: In case I can acquire a bit more funding from my client, is it possible to fund a specific feature by buying you "several coffees"? I would love to support your work financially and consequently improve the quality for everyone else using it. In this early phase I just want to know if this is possible at all.
Thanks for your answer in advance and kind regards!
The text was updated successfully, but these errors were encountered: