Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 'Sells This Ship' shipyard colour not displaying #3733

Closed
Zitchas opened this issue May 6, 2018 · 3 comments
Closed

Bug: 'Sells This Ship' shipyard colour not displaying #3733

Zitchas opened this issue May 6, 2018 · 3 comments

Comments

@Zitchas
Copy link
Member

Zitchas commented May 6, 2018

Version: 0.9.9 (MCO's build from Jenkin's, May 5th build)
Not using plug-ins or modifications.

What is expected:
That when clicking on a ship in the shipyard section of the map, that planets with shipyards that sell that ship will change to the orange "Sells This Ship" colour.

What happens:
There is no change to the map. It simply displays which planets have shipyards and which do not.

Other notes:
This appears to be something that happened between the previous build (several months old) and the May 5th build, as in the previous one it appeared to work.

The attached picture shows what the map looks like while having the Scout selected.

shipyard sells this ship not working

@Wrzlprnft
Copy link
Contributor

7d74467#commitcomment-28869567

@MCOfficer
Copy link
Collaborator

MCOfficer commented May 7, 2018

for reference, may the 5th build was at commit 1f039f0 (after 7d74467).
for the future, please either include the build number (# 17) or the latest commit hash as found in the build title.

@Zitchas
Copy link
Member Author

Zitchas commented May 7, 2018

Will do. Thanks!

Just to confirm that I'm doing this right:

This problem has been fixed as of build #19 ( 865b70d ).

@Zitchas Zitchas closed this as completed May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants